feature: add support for the newest variables in mcaf-workspace, set assessments_enabled to true by default as is best practise, optimize optionals
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
…assessments_enabled to true by default as is best practise
marwinbaumannsbp
force-pushed
the
upgrade-mcaf-workspace
branch
from
8e89c0a to
3267658
Compare
marwinbaumannsbp
force-pushed
the
upgrade-mcaf-workspace
branch
from
0d721b1 to
7d67002
Compare
marwinbaumannsbp
changed the title
assessments_enabled to true by default as is best practiseassessments_enabled to true by default as is best practise, optimize optionals
shoekstra
requested changes
Jul 30, 2024
shoekstra
previously approved these changes
Jul 30, 2024
Co-authored-by: Stephen Hoekstra <[email protected]>
marwinbaumannsbp
force-pushed
the
upgrade-mcaf-workspace
branch
from
0038d6c to
1a24213
Compare
shoekstra
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the newest variables in mcaf-workspace
allow_destroy_planassessments_enabled-> set to true by defaultauto_apply_run_triggerdescriptiontrigger_patternsOptimize optionals
Removed the
nullvalues in the optional vars. e.g.optional(string, null)->optional(string)