Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolving an error in the inheritance behaviour of notification_configuration and team_access #61

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

marwinbaumannsbp
Copy link
Contributor

Terraform does not treat these variables as an empty map but as tomap({}):

  "baseline-backup-non-prod" = {
    "backup-non-prod" = {
      "arn" = ""
      "notification_configuration" = tomap({})
      "workspace_id" = "ws-cphr4aX68NopxyJA"
      "workspace_name" = "backup-non-prod"
    }
While this behaviour is expected:
> {} != {} ? "additional" : "default"
"default"

This is the actual behaviour:
> tomap({}) != {} ? "additional" : "default"
"additional"

When modifying the input to null this can be resolved, and will still resolve to an empty map because of the defaults in mcaf-workspace. 

@github-actions github-actions bot added the bug Something isn't working label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@marwinbaumannsbp marwinbaumannsbp changed the title fix: resolving an error in the inheritance behaviour of notification_configuration and team_access fix: resolving an error in the inheritance behaviour of notification_configuration and team_access Aug 8, 2024
@marwinbaumannsbp marwinbaumannsbp merged commit 0b35c0d into master Aug 8, 2024
@marwinbaumannsbp marwinbaumannsbp deleted the inheritance branch August 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants