feat: add SG as input (refactored) #68
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
stefanwb
force-pushed
the
stefanwb/securitygroup-refactor
branch
6 times, most recently
from
03cf265 to
8bf4754
Compare
stefanwb
force-pushed
the
stefanwb/securitygroup-refactor
branch
from
8a60c22 to
3808df4
Compare
…bject that allows validating all the security group related values * Create local variable to determine SG creation making the code more readable. Removes default value for from- and to_ports as this is in line with the expected value when allowing all ip_protocols. * Adds validation on security_group_config. * An empty config means to not create a SG. Signed-off-by: Stefan Wessels Beljaars <[email protected]>
* fix trying to create a aws_iam_role_policy when no policy is given * fix when role_arn is set, do not create a role in this module and create an empty role when create_policy is set to false Signed-off-by: Stefan Wessels Beljaars <[email protected]>
Signed-off-by: Stefan Wessels Beljaars <[email protected]>
Signed-off-by: Stefan Wessels Beljaars <[email protected]>
Signed-off-by: Stefan Wessels Beljaars <[email protected]>
stefanwb
force-pushed
the
stefanwb/securitygroup-refactor
branch
from
c61428e to
1072fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.