breaking: VPC configuration refactor #72
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all the VPC related configuration in to a single
vpc_config
variable.Currently the following variables are used for configuring a Lambda to run in a VPC:
subnet_ids
security_group_name_prefix
security_group_ids
security_group_egress_rules
This should improve/simplify usage of the module and also make it clearer what you need to do if you want to run it in a VPC: Set
vpc_config
.Removed the
security_group_egress_rules
variable, thought is that passing your own SG is the way to go if you want to configure a Security Group.Also added the (new) attribute
ipv6_allowed_for_dual_stack
.If approved/ok I'll spend some time on the examples and writing it down in
Updrading.md