Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: VPC configuration refactor #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fatbasstard
Copy link
Contributor

This PR refactors all the VPC related configuration in to a single vpc_config variable.

Currently the following variables are used for configuring a Lambda to run in a VPC:

  • subnet_ids
  • security_group_name_prefix
  • security_group_ids
  • security_group_egress_rules

This should improve/simplify usage of the module and also make it clearer what you need to do if you want to run it in a VPC: Set vpc_config.

Removed the security_group_egress_rules variable, thought is that passing your own SG is the way to go if you want to configure a Security Group.

Also added the (new) attribute ipv6_allowed_for_dual_stack.

If approved/ok I'll spend some time on the examples and writing it down in Updrading.md

@github-actions github-actions bot added the breaking This change is not backwards compatible label Mar 14, 2024
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change is not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant