feature: Refactor role and policy #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
fatbasstard
force-pushed
the
fvb/role-refactor
branch
from
2fdcf6a to
bc33e4f
Compare
fatbasstard
added
breaking
fatbasstard
force-pushed
the
fvb/role-refactor
branch
from
9f97fee to
f5c7ef8
Compare
fatbasstard
force-pushed
the
fvb/role-refactor
branch
from
ce4d349 to
1f8777e
Compare
fatbasstard
force-pushed
the
fvb/role-refactor
branch
from
d3333bb to
8f41ae8
Compare
jverhoeks
approved these changes
May 31, 2024
|
LGTM, also have bugfix PR pending on this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all the logic and complexity of creating roles and policies by replacing it with the mcaf-role module.
Unfortunately the
create_policyboolean is still needed since TF doesn't like thevar.string !== nullchecks