Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for Jupyter to README.md #132

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kloimhardt
Copy link

This is a suggestion for a usage description of Noj+Jupyter. It could be included in any other place than README.md

@daslu
Copy link
Member

daslu commented Feb 7, 2025

@kloimhardt
This looks great to me, so clear and helpful.

One little comment:
You refer to the noj-v2-getting-started notebook, but at the moment, its visualizations will actually fail in Jupyter (discussed here.

We'll probably have better self-contained code examples in the coming days. For now, it might be better to avoid this specific one.

@daslu
Copy link
Member

daslu commented Feb 7, 2025

@kloimhardt @behrica

I am proposing the following -- what do you think?

  • To solve the problem of the changing version, we can include the above text in a chapter of a Noj book rather than the README. In that chapter, we will fetch the current version string and print the code relevant to that version.

  • We will add a very basic Getting Started chapter, that will include a few code examples that are currently compatible with the Clojupyter JAR. We will link to that chapter as a code example, rather than to the currently linked tutorial (which is currently not supported in Clojupyter).

@kloimhardt
Copy link
Author

@daslu Sounds good. This PR was just a proposal. I am not keen to actually getting it pulled. It can be closed at any time. But I leave it open as a reminder for now.

@daslu
Copy link
Member

daslu commented Feb 7, 2025

Thanks.
Maybe we can merge it as a first step, and then (if you wish), collaborate on turning it into a chapter in the book.

Let us see what @behrica thinks.

@behrica
Copy link
Member

behrica commented Feb 8, 2025

looks good to me.
Maybe you can add additional a link to https://github.com/qubit55/clojupyter_colab_setup
as an alternative way to run this kernel in Google Colab ?

@kloimhardt
Copy link
Author

Added the Colab link and removed the link to the getting-started notebook. Feedback welcome. However, this text is free to use for anyone and any purpose deemed to fit, without any need to get an opinion from my side.

@daslu
Copy link
Member

daslu commented Feb 8, 2025

@behrica I'm confused.

If I understand correctly, the Colab setup does not support Noj yet.
qubit55/clojupyter_colab_setup#5

So, isn't it confusing to mention it here?

@behrica
Copy link
Member

behrica commented Feb 8, 2025 via email

@behrica
Copy link
Member

behrica commented Feb 8, 2025

Nevertheless it's worth to link to it . It's not obvious how to do this. Hopefully soon it's configurable .

@daslu
Copy link
Member

daslu commented Feb 8, 2025

@behrica Thanks.

Would you like to merge this and then revise the text?

@daslu
Copy link
Member

daslu commented Feb 10, 2025

I suggest adding a clarifying note that currently Jupyter supports most but not all data visualization kinds.

@daslu
Copy link
Member

daslu commented Feb 11, 2025

Should we merge this?

@kloimhardt
Copy link
Author

I am closing this PR to clean the slate a bit. This PR is about a few lines of text only. Which are not lost and can be copied into any place desired (maybe README.md is not the right place).

@kloimhardt kloimhardt closed this Feb 13, 2025
@daslu
Copy link
Member

daslu commented Feb 13, 2025

@behrica
I think we can merge this.

@daslu daslu reopened this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants