Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adiciona modelos e Admin para Journal TocSections. #872

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

samuelveigarangel
Copy link
Collaborator

@samuelveigarangel samuelveigarangel commented Oct 8, 2024

O que esse PR faz?

Adiciona modelos e Admin para Journal TocSections.

Onde a revisão poderia começar?

pelos commits

Como este poderia ser testado manualmente?

  1. Acessar área administrativa
  2. Acessar seção de Table of Contents
  3. Adicionar um objeto em JournalTocSection

Algum cenário de contexto que queira dar?

N/A

Screenshots

image
image

            "toc_items": [
                {
                    "value": "texto 1",
                    "language": "pt"
                },
                {
                    "value": "texto 2",
                    "language": "en"
                }
            ],

Quais são tickets relevantes?

#871

Referências

N/A

def __str__(self):
related_values = self.toc_items.all()
value_list = [f"{toc_section.text} ({toc_section.language.code2})" for toc_section in related_values]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelveigarangel sugestão de melhoria: apresentar 1 título apenas, mas adicionar entre parêntesis todos os idiomas.



class TOC(Orderable, TextWithLang, CommonControlField):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelveigarangel nome mais adequado é TocSection ou TocItem. TOC = Sumário. E isso não é o sumário. Sumário é um conjunto de seções.

@robertatakenaka robertatakenaka merged commit b120b04 into scieloorg:main Oct 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants