Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild website each week after data bundle is published #1

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Jan 10, 2025

No description provided.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you need to merge this yourself.

@@ -144,7 +144,16 @@ jobs:

You can generate a report from this data using [devstats](https://github.com/scientific-python/devstats).

Reports for some key ecosystem packages are available at https://devstats.scientific-python.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the link under a text rather than directly?

Suggested change
Reports for some key ecosystem packages are available at https://devstats.scientific-python.org
Reports for some key ecosystem packages are available at [the devstats website](https://devstats.scientific-python.org)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would be a good way to make people aware of the website URL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, nevermind, this is all good, it's very unlikely to look at the logs where this appears with a screen reader or such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the release page description.

@stefanv
Copy link
Member Author

stefanv commented Jan 11, 2025

Thanks for the review, Brigitta!

@stefanv stefanv merged commit 89a5664 into main Jan 11, 2025
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants