Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use a non-default path to run the upload action #100

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

This should address the testing flaws that @MridulS discovered in PRs #96 and #98.

  • Don't rely on the action's $GITHUB_ACTION_PATH variable being the current directory during testing.

* Don't rely on the action's '$GITHUB_ACTION_PATH' variable being
  the current directory during testing.
@matthewfeickert matthewfeickert requested a review from a team September 30, 2024 16:35
@matthewfeickert matthewfeickert self-assigned this Sep 30, 2024
@bsipocz bsipocz merged commit 9d888d2 into main Sep 30, 2024
4 checks passed
@bsipocz bsipocz deleted the ci/test-better branch September 30, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants