Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Require upload dates to be valid to schedule package for removal #74

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 1, 2024

Resolves #73

To guard against invalid dates being viewed as being older than the removal threshold date (c.f. numpy/numpy#25907 (comment)) first check that the upload date is YYYY-MM-DD formatted. If not, warn in the logs and skip the offending package.

* To guard against invalid dates being viewed as being older than the
  removal threshold date first check that the upload date is YYYY-MM-DD
  formatted. If not, warn in the logs and skip the offending package.
@matthewfeickert matthewfeickert requested review from a team March 1, 2024 16:24
@matthewfeickert matthewfeickert self-assigned this Mar 1, 2024
@MridulS
Copy link
Member

MridulS commented Mar 1, 2024

The first attempt on remove-old-wheels action was a API failure right?

@matthewfeickert
Copy link
Member Author

The first attempt on remove-old-wheels action was a API failure right?

The error was on the cleanup step of the upload CI, but it was a an API failure

  anaconda --token *** remove \
    --force \
    "scientific-python-nightly-wheels/test-package"
  shell: /usr/bin/bash -l {0}
  env:
    MAMBA_ROOT_PREFIX: /home/runner/micromamba
    MAMBA_EXE: /home/runner/micromamba-bin/micromamba
    CONDARC: /home/runner/work/_temp/setup-micromamba/.condarc
Using Anaconda API: https://api.anaconda.org
Error: [ERROR] ('?: Undefined error ([DELETE] https://api.anaconda.org/package/scientific-python-nightly-wheels/test-package -> 524)', 524)
Error: Process completed with exit code 1.

but as this was a cleanup step and clearly an API failure on Anaconda Cloud's side this was fixed by just retriggering.

@matthewfeickert matthewfeickert merged commit 535c72c into main Mar 1, 2024
3 checks passed
@matthewfeickert matthewfeickert deleted the ci/check-date branch March 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jq parsing error of upload date in remove old wheels CI workflow can remove packages
2 participants