Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix spelling of test package name #79

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 17, 2024

python -m build --outdir ./dist tests/test_package now creates test_package-0.0.1.tar.gz and test_package-0.0.1-py3-none-any.whl thus this PR fixes the spelling for the CI to pass.

@bsipocz bsipocz added the CI label Apr 17, 2024
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsipocz. This is (I'm assuming) a change in how hatchling does things, as build shouldn't control this, so for posterity and my own education I'll check on this (unless @henryiii knows of the top of his head).

@matthewfeickert matthewfeickert merged commit a5d8097 into scientific-python:main Apr 17, 2024
1 of 2 checks passed
@matthewfeickert
Copy link
Member

Ah yes. In hatchling v1.22.0

Metadata for the wheel target now defaults to the PKG-INFO metadata within source distributions

Nice.

@henryiii
Copy link

I thought hatchling has normalized SDist names for among time? Setuptools just changed to do it too, but I though hatching basically always did it?

@henryiii
Copy link

Yes, it’s setuptools:

requires = ["setuptools>=61.0"]

All the other build backends have done this since nearly the beginning.

@matthewfeickert
Copy link
Member

matthewfeickert commented Apr 17, 2024

Oh right. I just totally forgot that I had to use setuptools in PR #27 because anaconda/anaconda-client#676 blocks using hatchling. I should see if this is still the case.

edit: This is still the case for

- name: anaconda-client
version: 1.12.3

@bsipocz bsipocz deleted the CI_fix_step branch June 18, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants