Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle scale->alpha parameter rename in 0.9 #43

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 3, 2024

should fix nightly build after FEniCS/dolfinx#3434

not sure if you care about maintaining this compatibility, or if you'd rather update to require 0.9.

@jorgensd
Copy link
Member

jorgensd commented Oct 3, 2024

For now the plan is to keep backwards compatibility for 1 version (i.e. 0.8 and main), (0.8, 0.9, main), (0.9,0.10, main).
This looks good to me and should probably be propagated through the repo, as there are currently some if else statements that does inexact version handling

@jorgensd jorgensd merged commit a2a6fb4 into scientificcomputing:main Oct 3, 2024
6 checks passed
@minrk minrk deleted the alpha-scale branch October 3, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants