Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model for required fields #136

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Conversation

orangewolf
Copy link
Contributor

Story

#130

Expected Behavior Before Changes

Any model with out a year was throwing an error

Expected Behavior After Changes

Only throw an error on the year if the year is required

Notes

Asking Christi this question:

  • We validate the format and year fields. If the field is required on a work type and it does not match the format we through an error. What do we do if it is not required? Do we make it blank or do we still throw an error on that records import?

@orangewolf orangewolf merged commit 2e256a7 into main Aug 13, 2023
1 of 2 checks passed
@orangewolf orangewolf deleted the use_model_for_required_fields branch August 13, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant