Is public basic (#568)

* use env vars

* demo_user

* use env

* use env

app/controllers/application_controller.rb

@@ -56,7 +56,7 @@ def authenticate_if_needed
       return true if Rails.env.test?
       if (is_hidden || is_staging) && !is_api_or_pdf
         authenticate_or_request_with_http_basic do |username, password|
-          username == "samvera" && password == "hyku"
+          username == ENV.fetch("HYKU_DEMO_USER") && password == ENV.fetch("HYKU_DEMO_PASSWORD")
         end
       end
     end

ops/production-deploy.tmpl.yaml

@@ -134,6 +134,10 @@ extraEnvVars: &envVars
     value: iro.bl.uk
   - name: HYKU_SMTP_SETTINGS
     value: '{"from":"[email protected]","user_name":"apikey","password":"$SMTP_PASSWORD","address":"smtp.sendgrid.net","domain":"bl.uk","port":"587","authentication":"plain","enable_starttls_auto":true}'
+  - name: HYKU_DEMO_USER
+    value: "bl_hyku_demo_user"
+  - name: HYKU_DEMO_PASSWORD
+    value: $HYKU_DEMO_PASSWORD
   - name: SMTP_ADDRESS
     value: smtp.sendgrid.net
   - name: SMTP_DOMAIN

ops/staging-deploy.tmpl.yaml

@@ -141,6 +141,10 @@ extraEnvVars: &envVars
     value: "true"
   - name: HYKU_ROOT_HOST
     value: bl-staging.notch8.cloud
+  - name: HYKU_DEMO_USER
+    value: "bl_hyku_demo_user"
+  - name: HYKU_DEMO_PASSWORD
+    value: $HYKU_DEMO_PASSWORD
   - name: S3_DOWNLOADS
     value: "true"
   - name: SMTP_ADDRESS