🎁 Adding PDF Split Page Checks #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if we'd already pre-processed a PDF split, we would again re-process that split (as there was no check for existing pages). With this commit, we check for those pre-processed pages. One critical bit of conversation, is that one work might have multiple PDFs uploaded. Therefore, it is important to have those PDFs pages write to different "sub-directories". I'm putting this hear so we can account for that in a test audit of some kind. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/330 - scientist-softserv/iiif_print#220 Co-authored-by: Rob Kaufman <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
Updating a bit of documentation and reworking the filename to account for a work having multiple PDFs. - https://github.com/scientist-softserv/adventist-dl/issues/330 - scientist-softserv/iiif_print#220
jeremyf
force-pushed
the
adding-pdf-split-finder
branch
from
fcac7cf
to
a45e57f
Compare
Prior to this commit, we didn't have a spec for the S3 behavior. We now have a test for an S3 Faux Bucket. Related to: - https://github.com/scientist-softserv/adventist-dl/issues/330 - scientist-softserv/iiif_print#220
jeremyf
force-pushed
the
adding-pdf-split-finder
branch
from
b5a16e2
to
9ca9fe8
Compare
ShanaLMoore
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Adding PDF Split Page Checks
c62729f
Prior to this commit, if we'd already pre-processed a PDF split, we
would again re-process that split (as there was no check for existing
pages).
With this commit, we check for those pre-processed pages.
One critical bit of conversation, is that one work might have multiple
PDFs uploaded. Therefore, it is important to have those PDFs pages
write to different "sub-directories". I'm putting this here so we can
account for that in a test audit of some kind.
Related to:
Co-authored-by: Rob Kaufman [email protected]
Co-authored-by: Kirk Wang [email protected]
☑️ Verifying pdf splitter finds pre-existing files
a45e57f
Updating a bit of documentation and reworking the filename to account
for a work having multiple PDFs.
☑️ Refining globbed_tail_locations for S3
9ca9fe8
Prior to this commit, we didn't have a spec for the S3 behavior. We now
have a test for an S3 Faux Bucket.
Related to: