🐛 Improve error handling due to missing parent_work_identifier_property_name value #289
Comments
ShanaLMoore
changed the title
jeremyf
added a commit
that referenced
this issue
Nov 27, 2023
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world. With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone. Note: sniffing out where this file exists in SpaceStone is a very fragile process. Closes #289 Related to: - #289
jeremyf
added a commit
that referenced
this issue
Nov 28, 2023
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world. With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone. Note: sniffing out where this file exists in SpaceStone is a very fragile process. Closes #289 Related to: - #289
jeremyf
added a commit
that referenced
this issue
Nov 28, 2023
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world. With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone. Note: sniffing out where this file exists in SpaceStone is a very fragile process. Closes #289 Related to: - #289
|
@jeremyf is there any way to QA this or should it be closed as done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Story
The derivative rodeo service defines a class attribute:
class_attribute :parent_work_identifier_property_name, default: 'aark_id'This attribute is not required, and absence of the metadata causes an error
TypeError: no implicit conversion of nil into StringinIiifPrint::Jobs::ChildWorksFromPdfJobAcceptance Criteria
Screenshots / Video
Testing Instructions and Sample Files
Notes
The text was updated successfully, but these errors were encountered: