🐛 Ease how we determine preprocessed location #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world. With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone. Note: sniffing out where this file exists in SpaceStone is a very fragile process. Closes #289 Related to: - #289
Prior to this commit, when we'd push this to CI, we'd continue to rebuild the `.internal_test_app`; this resulted in 2 hour build times. By adding it to the repository, we explicitly say when we want to rebuild the internal test application (e.g. by deleting it and letting a local `bundle exec rake` rebuild it). See the README.md for more details.
I generated this file by: 1. `brew install ggshield` 2. `ggshield secret scan path .internal_test_app --recursive` 3. `ggshield secret ignore --last-found` First, to install the Git Guardian `ggshield`. Then to scan the newly committed `.internal_test_app`. Finally ignoring the last found secrets.
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 8878544 | Rails Master Key | f603571 | .internal_test_app/config/master.key | View secret |
| 8878545 | Generic High Entropy Secret | f603571 | .internal_test_app/config/initializers/devise.rb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world.
With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone.
Note: sniffing out where this file exists in SpaceStone is a very fragile process.
Closes #289
Related to: