♻️ Extract direct ActiveFedora calls to adapter #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
extract-active-fedora-calls-to-adapter
branch
2 times, most recently
from
0565150
to
897a5c5
Compare
jeremyf
force-pushed
the
extract-active-fedora-calls-to-adapter
branch
from
897a5c5
to
086b624
Compare
With Valkyrie looming large, this change refactors the code towards an adapter pattern; one that will allow for creating a Valkyrie adapter and then configuring IIIFPrint accordingly. We'll also need to consider how we duplicate the actor work within a transaction and/or publisher/listener setup. There are likely other places where we're making assumptions about presenters and/or the data models we're processing.
jeremyf
force-pushed
the
extract-active-fedora-calls-to-adapter
branch
from
086b624
to
0b9515e
Compare
ShanaLMoore
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Valkyrie looming large, this change refactors the code towards an
adapter pattern; one that will allow for creating a Valkyrie adapter and
then configuring IIIFPrint accordingly.
We'll also need to consider how we duplicate the actor work within a
transaction and/or publisher/listener setup.
There are likely other places where we're making assumptions about
presenters and/or the data models we're processing.
Related to: