🐛 Fix date indexing to return more than YYYY #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
reviewed
Mar 7, 2024
jeremyf
reviewed
Mar 7, 2024
kirkkwang
force-pushed
the
i973-date-sorting
branch
from
eef087e
to
71560ba
Compare
Prior to this commit when the date_created property was indexed, only the year was indexed. If the input was something like "2024-01-01" then `date_ssi` would only be "2024". This commit will index YYYY-MM-DD, YYYY-MM, and YYYY if given. Anything other than those three formats will be indexed as is and won't work correctly with sorting or range queries. Ref: - #973
kirkkwang
force-pushed
the
i973-date-sorting
branch
from
71560ba
to
23a8ec6
Compare
jeremyf
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Prior to this commit when the date_created property was indexed, only the year was indexed. If the input was something like "2024-01-01" then
date_ssiwould only be "2024". This commit will index YYYY-MM-DD, YYYY-MM, and YYYY if given. Anything other than those three formats will be indexed as is and won't work correctly with sorting or range queries.Ref:
Expected Behavior Before Changes
YYYY-MM-DD, YYYY-MM, and YYYY dates were indexed just as YYYY.
Expected Behavior After Changes
YYYY-MM-DD, YYYY-MM, and YYYY dates are indexes as YYYY-MM-DD, YYYY-MM, and YYYY respectively.