I657 update banner image #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will change banner_image to banner_images.
kirkkwang
force-pushed
the
i657-update-banner-image
branch
from
a5753e6
to
753da3b
Compare
This commit allows the admin to upload multiple banners to the homepage through the dashboard. The homepage will randomly select a banner and then cycle through the uploaded banners. We introduce a new uploader, `Hyku::UploadedFileUploader`, to handle the multiple file uploads and change the concept of banner_image to banner_images. Ref: - #657
kirkkwang
force-pushed
the
i657-update-banner-image
branch
from
753da3b
to
7624705
Compare
We are experiencing build issues, the CI is throwing the following: ``` docker-compose: command not found ``` Updating to v0.0.15 because it makes the switch from `docker-compose` to `docker compose`.
ShanaLMoore
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
🚧 Set up database migration
1bc1394
This commit will change banner_image to banner_images.
🎁 Allow admins to upload multiple banners
7624705
This commit allows the admin to upload multiple banners to the homepage
through the dashboard. The homepage will randomly select a banner and
then cycle through the uploaded banners. We introduce a new uploader,
Hyku::UploadedFileUploader, to handle the multiple file uploads andchange the concept of banner_image to banner_images.
Ref:
🤖 Update github actions to v0.0.15
22cc763
We are experiencing build issues, the CI is throwing the following:
Updating to v0.0.15 because it makes the switch from
docker-composetodocker compose.Expected Behavior Before Changes
Admins can only upload one banner image.
Expected Behavior After Changes
Admins can upload one or more banner images.
Screenshots / Video
Zight.Recording.2024-08-05.at.08.36.45.mp4