Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

321-restore-login #388

Merged
merged 1 commit into from
Feb 28, 2024
Merged

321-restore-login #388

merged 1 commit into from
Feb 28, 2024

Conversation

alishaevn
Copy link
Contributor

Story

able to log in again

the signIn function from "next-auth/react" uses fetcher and returns a 404 error response. throwing that error causes an OAUTH_CALLBACK_HANDLER_ERROR, which prevents users from signing in. signIn doesn't pass a url to fetcher. the check below ensures that other errors still get thrown

Screenshots / Video

Zight.Recording.2024-02-28.at.04.40.38.PM.mp4

the `signIn` function from "next-auth/react" uses `fetcher` and returns
a 404 error response. throwing that error causes an `OAUTH_CALLBACK_HANDLER_ERROR`,
which prevents users from signing in. `signIn` doesn't pass a url to `fetcher`.
the check below ensures that other errors still get thrown

- ref: #321
@alishaevn alishaevn linked an issue Feb 28, 2024 that may be closed by this pull request
3 tasks
@alishaevn alishaevn merged commit 2c1650b into main Feb 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore login ability
1 participant