Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add standard venv names and notebook checkpoints to gitignore #229

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

phinate
Copy link
Contributor

@phinate phinate commented Jun 7, 2021

Tiny little PR for quality of life when people make venvs to look at cabinetry :)

feel free to do yourself if you don't want to give me easy contributor status ;)

@alexander-held
Copy link
Member

Thanks, this is very useful to have! The CI issue is unrelated and another instance of #199, I will get that fixed separately.

@phinate
Copy link
Contributor Author

phinate commented Jun 7, 2021

fwiw, I think these and more are covered in github's standard python template, may be worth looking at: https://github.com/github/gitignore/blob/master/Python.gitignore

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI issue should be fixed after rebasing on master. I had a look at the template you linked and would suggest adding .ipynb_checkpoints to this PR. Happy to extend the gitignore further if required in practice.

@phinate
Copy link
Contributor Author

phinate commented Jun 7, 2021

should be good now!

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #229 (79ac627) into master (e773941) will not change coverage.
The diff coverage is n/a.

❗ Current head 79ac627 differs from pull request most recent head 96f1429. Consider uploading reports for the commit 96f1429 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1727      1727           
  Branches       268       268           
=========================================
  Hits          1727      1727           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e773941...96f1429. Read the comment docs.

@alexander-held alexander-held changed the title Update .gitignore to ignore standard venv names chore: add standard venv names and notebook checkpoints to gitignore Jun 7, 2021
@alexander-held
Copy link
Member

The CI fails during Codecov upload, which should have been fixed by #230 upon which this branch is based. It is currently unclear to me why the token is not picked up in the CI here.

@alexander-held
Copy link
Member

This is likely related to codecov/codecov-action#330, so let's see whether it can get resolved centrally. The fact that #230 worked fine may have just been a lucky coincidence.

@alexander-held
Copy link
Member

Independent of Codecov, the release of mypy 0.900 requires another small update which will go in via #232. With that done and Codecov stabilized, it should then be able to get CI to pass here again.

@alexander-held alexander-held merged commit d888ec0 into scikit-hep:master Jun 21, 2021
@alexander-held
Copy link
Member

With #232 done this PR now passed CI as well. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants