-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add standard venv names and notebook checkpoints to gitignore #229
Conversation
Thanks, this is very useful to have! The CI issue is unrelated and another instance of #199, I will get that fixed separately. |
fwiw, I think these and more are covered in github's standard python template, may be worth looking at: https://github.com/github/gitignore/blob/master/Python.gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI issue should be fixed after rebasing on master. I had a look at the template you linked and would suggest adding .ipynb_checkpoints
to this PR. Happy to extend the gitignore further if required in practice.
should be good now! |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1727 1727
Branches 268 268
=========================================
Hits 1727 1727 Continue to review full report at Codecov.
|
79ac627
to
9b5ca59
Compare
The CI fails during Codecov upload, which should have been fixed by #230 upon which this branch is based. It is currently unclear to me why the token is not picked up in the CI here. |
This is likely related to codecov/codecov-action#330, so let's see whether it can get resolved centrally. The fact that #230 worked fine may have just been a lucky coincidence. |
Independent of Codecov, the release of |
9b5ca59
to
96f1429
Compare
With #232 done this PR now passed CI as well. Thanks for the contribution! |
Tiny little PR for quality of life when people make venvs to look at cabinetry :)
feel free to do yourself if you don't want to give me easy contributor status ;)