Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Extend coverage of classes and add cover of read_lhe #143

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

eduardo-rodrigues
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues commented Aug 30, 2022

First batch of work to achieve reasonable coverage for the main package functionality.

What is missing is largely coverage for exceptions, the scope of issue #142.

* Add tests for fromstring methods.
* Add tests for read_lhe functions.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 67.28% // Head: 67.28% // No change to project coverage 👍

Coverage data is based on head (678b37d) compared to base (678b37d).
Patch has no changes to coverable lines.

❗ Current head 678b37d differs from pull request most recent head 4eb7f5a. Consider uploading reports for the commit 4eb7f5a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   67.28%   67.28%           
=======================================
  Files           2        2           
  Lines         217      217           
  Branches       57       57           
=======================================
  Hits          146      146           
  Misses         64       64           
  Partials        7        7           
Flag Coverage Δ
unittests-3.10 65.89% <0.00%> (ø)
unittests-3.6 64.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eduardo-rodrigues
Copy link
Member Author

Morning @matthewfeickert, this concludes a push in these last few days to finalise some long-standing bits of work and increase test coverage from about 60% to close to 75%. I consider myself done for a new release, which will enable us to publish also in Conda :-).

@eduardo-rodrigues
Copy link
Member Author

Morning Matthew. Happy to get this in and release 0.4.0?

@eduardo-rodrigues
Copy link
Member Author

Thanks for the update.

@matthewfeickert matthewfeickert changed the title feat: better coverage of classes and read_lhe type of functions test: Extend coverage of classes and add cover of read_lhe Sep 7, 2022
@matthewfeickert matthewfeickert merged commit 37f2dc2 into master Sep 7, 2022
@matthewfeickert matthewfeickert deleted the eduardo-test-coverage-2 branch September 7, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants