-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: use pyproject.toml #618
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 39 61 +22
Lines 4616 6006 +1390
Branches 487 449 -38
===========================================
+ Hits 4616 6006 +1390 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
Few comments inline. Also, do we still need the MANIFEST.in?
This reverts commit f8ded3f.
It's not a need but a I see that some libraries still have it. Other don't. If we keep it, I suggest to update it with a mention to the notebooks:
|
About |
Here is the content of the dist/mapie-version.tar.gz built without setup.py nor MANIFEST.in: LICENSE It seems ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Let's update HISTORY.rst
Description
ENH: use pyproject.toml
Fixes #512
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
make lint
make type-check
make tests
make coverage
make doc
make doctest