Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: use pyproject.toml #618

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

C-BdB
Copy link
Collaborator

@C-BdB C-BdB commented Feb 28, 2025

Description

ENH: use pyproject.toml

Fixes #512

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • unit tests and coverage

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully: make lint
  • Typing passes successfully: make type-check
  • Unit tests pass successfully: make tests
  • Coverage is 100%: make coverage
  • When updating documentation: doc builds successfully and without warnings: make doc
  • When updating documentation: code examples in doc run successfully: make doctest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (edb05bb).
Report is 854 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #618     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           39        61     +22     
  Lines         4616      6006   +1390     
  Branches       487       449     -38     
===========================================
+ Hits          4616      6006   +1390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Valentin-Laurent Valentin-Laurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!
Few comments inline. Also, do we still need the MANIFEST.in?

@C-BdB
Copy link
Collaborator Author

C-BdB commented Mar 3, 2025

Also, do we still need the MANIFEST.in?

It's not a need but a I see that some libraries still have it. Other don't. If we keep it, I suggest to update it with a mention to the notebooks:

include LICENSE
include AUTHORS.rst
recursive-exclude doc *
recursive-include examples *.py
recursive-include notebooks

@Valentin-Laurent
Copy link
Collaborator

About MANIFEST.in: let's see what's included without. I think we shouldn't include /doc, /examples, or /notebooks.

@C-BdB
Copy link
Collaborator Author

C-BdB commented Mar 4, 2025

About MANIFEST.in: let's see what's included without. I think we shouldn't include /doc, /examples, or /notebooks.

Here is the content of the dist/mapie-version.tar.gz built without setup.py nor MANIFEST.in:

LICENSE
PKG-INFO
mapie/
setup.cfg
AUTHORS.rst
MAPIE.egg-info/
README.rst
pyproject.toml

It seems ok.

Copy link
Collaborator

@Valentin-Laurent Valentin-Laurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Let's update HISTORY.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from setup.py to pyproject.toml
3 participants