Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sklearn #239

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix sklearn #239

wants to merge 13 commits into from

Conversation

PicoCentauri
Copy link
Collaborator

@PicoCentauri PicoCentauri commented Feb 13, 2025

Fixes #237

Reopening of #238

Adding fixes for updates with scikit-learn and scipy. Scikit-learn's estimator checks will fail when validate_data is not used. These fixes will pass scikit-learn's estimator checks but are causing unit tests to fail.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--239.org.readthedocs.build/en/239/

@PicoCentauri PicoCentauri force-pushed the fix-sklearn branch 2 times, most recently from 75e03da to 879057b Compare February 13, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep up with API changes of scikit-learn version 1.6.0
2 participants