Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCEM metadata #38

Open
wants to merge 120 commits into
base: devel
Choose a base branch
from
Open

OSCEM metadata #38

wants to merge 120 commits into from

Conversation

lolasanchezzz
Copy link

No description provided.

@lolasanchezzz lolasanchezzz marked this pull request as ready for review December 19, 2024 09:29
Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cryosparc is a non free software, try to avoid this requirement for the test. In case there is a Xmipp alternative, please use that protocols trying to reduce the external dependencies


@classmethod
def runCTFestimation(cls):
prot = cls.newProtocol(CistemProtCTFFind,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reduce the external dependencies, could you replace the cistemCTFFind for the one in XMIPP?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that for the test I would like to check that the protocol works with different plugins and does not raise errors.


@classmethod
def runPicking(cls):
prot = cls.newProtocol(SphireProtCRYOLOPicking,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to reduce the external dependencies, could you replace the cryolopicking for the one in XMIPP?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as with the previous comment, for the test I would like to check that the protocol works with different plugins and does not raise errors.

Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the new "issues" sonarCloud reports
At least the High severity ones

pointerClass='ProtAlignMovies',
help="Movie alignment used",
condition=CONDITION_MOVIES,
allowsNull=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is movieAlignment optional? just to confirm

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, the only compulsory input are the movies

Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants