-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSCEM metadata #38
base: devel
Are you sure you want to change the base?
OSCEM metadata #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cryosparc is a non free software, try to avoid this requirement for the test. In case there is a Xmipp alternative, please use that protocols trying to reduce the external dependencies
|
||
@classmethod | ||
def runCTFestimation(cls): | ||
prot = cls.newProtocol(CistemProtCTFFind, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to reduce the external dependencies, could you replace the cistemCTFFind for the one in XMIPP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that for the test I would like to check that the protocol works with different plugins and does not raise errors.
|
||
@classmethod | ||
def runPicking(cls): | ||
prot = cls.newProtocol(SphireProtCRYOLOPicking, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to reduce the external dependencies, could you replace the cryolopicking for the one in XMIPP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as with the previous comment, for the test I would like to check that the protocol works with different plugins and does not raise errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the new "issues" sonarCloud reports
At least the High severity ones
pointerClass='ProtAlignMovies', | ||
help="Movie alignment used", | ||
condition=CONDITION_MOVIES, | ||
allowsNull=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is movieAlignment optional? just to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, the only compulsory input are the movies
|
No description provided.