Fix ancestor removal logic #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jun 3, 2024
tests/graph_test.py
Outdated
| g2 = nx.DiGraph() | ||
| g2.add_edge('b', 'c') | ||
| graph['c'] = cb.Graph(g2) | ||
|
|
tests/graph_test.py
Outdated
| g.add_edge('c', 'd') | ||
| graph = cb.Graph(g) | ||
| graph['c'] = graph['c'] | ||
| assert 'a' in graph.to_networkx() |
There was a problem hiding this comment.
Does this work?
Suggested change
| assert 'a' in graph.to_networkx() | |
| assert graph.to_networkx() == g |
There was a problem hiding this comment.
Should be nx.utils.graphs_equal(graph.to_networkx(), g) for equality.
src/cyclebane/graph.py
Outdated
Comment on lines
34
to
36
| ancestors_descendants = { | ||
| ancestor: nx.descendants(graph_without_node, ancestor) for ancestor in ancestors | ||
| } |
There was a problem hiding this comment.
You could use
Suggested change
| ancestors_descendants = { | |
| ancestor: nx.descendants(graph_without_node, ancestor) for ancestor in ancestors | |
| } | |
| ancestors_descendants = [ | |
| (ancestor, nx.descendants(graph_without_node, ancestor)) for ancestor in ancestors | |
| ] |
to avoid computing hashes. And technically, you could also express the whole construction of to_remove as a list comprehension. (I'm surprised ruff didn't suggest the latter.)
jl-wynen
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first commit for actual change, second commit fixes ruff (mostly unrelated to this change).