fix: include resolution in stitched curve if present #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ess/reflectometry/tools.py
Outdated
| q_res = ( | ||
| sc.DataArray( | ||
| data=c.coords.get( | ||
| 'Q_resolution', sc.scalar(float('nan')) * sc.values(c.data.copy()) |
There was a problem hiding this comment.
Odd default. Is that really the unit you want? How about something like sc.full_like(c.coords['Q'], value=nan)?
src/ess/reflectometry/tools.py
Outdated
Comment on lines
289
to
291
| qs_avg = np.nansum(qs * inv_v, axis=0) / np.nansum( | ||
| ~np.isnan(qs) * inv_v, axis=0 | ||
| ) |
There was a problem hiding this comment.
Why are we using np.nansum instead of sc.nansum?
There was a problem hiding this comment.
That's the way it was done in ess.reflectometry.tools.scale_curves_to_overlap (for various reasons, we're using scipy there so it's easier to just convert to numpy types once instead of going back and forth in every iteration) and this was just copied from there.
Fixed now 👍
Comment on lines
+275
to
+278
| # This might need to be revisited. The question about how to combine curves | ||
| # with different Q-resolution is not completely resolved. | ||
| # However, in practice the difference in Q-resolution between different curves | ||
| # is small so it's not likely to make a big difference. |
There was a problem hiding this comment.
Maybe this should be discussed in the docstring instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Q_resolutioncoordinate to the combined reflectivity curve if the provided curves have aQ_resolutioncoordinate.