add tests

scipp · Aug 7, 2023 · f269631 · f269631
1 parent fb5bec2
commit f269631
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/plopp/plotting/plot.py b/src/plopp/plotting/plot.py
@@ -106,7 +106,6 @@ def plot(
         'vmax': vmax,
         'autoscale': autoscale,
         'figsize': figsize,
-        'legend': legend,
         **kwargs,
     }
 
@@ -128,6 +127,7 @@ def plot(
             *[Node(da) for da in data_arrays],
             errorbars=errorbars,
             mask_color=mask_color,
+            legend=legend,
             **common_args,
         )
     elif ndim == 2:

diff --git a/tests/plotting/plot_test.py b/tests/plotting/plot_test.py
@@ -376,3 +376,24 @@ def test_plot_pandas_dataframe():
     assert p.canvas.units['x'] == 'dimensionless'
     assert p.canvas.units['y'] == 'dimensionless'
     assert len(p._view.artists) == 4
+
+
+def test_hide_legend():
+    da1 = data_array(ndim=1)
+    da2 = da1 * 3.3
+    p = pp.plot({'a': da1, 'b': da2}, legend=False)
+    leg = p.ax.get_legend()
+    assert leg is None
+
+
+def test_legend_location():
+    da1 = data_array(ndim=1)
+    da2 = da1 * 3.3
+    data = {'a': da1, 'b': da2}
+    leg1 = pp.plot(data, legend=(0.5, 0.5)).ax.get_legend().get_window_extent().bounds
+    leg2 = pp.plot(data, legend=(0.9, 0.5)).ax.get_legend().get_window_extent().bounds
+    leg3 = pp.plot(data, legend=(0.5, 0.9)).ax.get_legend().get_window_extent().bounds
+    assert leg2[0] > leg1[0]
+    assert leg2[1] == leg1[1]
+    assert leg3[1] > leg1[1]
+    assert leg3[0] == leg1[0]