Merge pull request #180 from scipp/relax-warning-policy

Do not warn about fallback for empty groups

src/scippnexus/base.py

@@ -357,6 +357,11 @@ def isclass(x):
             return self._get_children_by_nx_class(sel)
 
         dg = self._nexus.read_children(sel)
+        if not dg:
+            # Bail out early to avoid fallback warnings. Everything is optional in
+            # NeXus so we cannot assume that the group is invalid (in contrast to
+            # likely partially incomplete groups that will fail to assemble below).
+            return dg
         try:
             dg = self._nexus.assemble(dg)
         except (sc.DimensionError, NexusStructureError) as e:

tests/nexus_test.py

@@ -1,6 +1,8 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2023 Scipp contributors (https://github.com/scipp)
 
+import warnings
+
 import h5py
 import numpy as np
 import pytest
@@ -552,3 +554,11 @@ def test_create_field_saves_errors(nxroot):
     # Use allclose instead of identical because the variances are stored as stddevs
     # which loses precision.
     assert sc.allclose(loaded, data.rename_dims(d0='dim_0'))
+
+
+@pytest.mark.parametrize('nxclass', [NXlog, NXmonitor, NXdetector, NXevent_data])
+def test_empty_class_does_not_warn(nxroot, nxclass):
+    log = nxroot['entry'].create_class('log', nxclass)
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        log[()]