Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to copier #170

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Move to copier #170

merged 7 commits into from
Oct 25, 2023

Conversation

SimonHeybrock
Copy link
Member

No description provided.

- run: tox -e ${{ matrix.tox }}
os: ['ubuntu-20.04']
python:
- version: '${{needs.formatting.outputs.min_python}}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now this only runs with a single python version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I considered keeping multiple versions, but felt there was little benefit at this point.

- run: conda install -c conda-forge --yes anaconda-client
- run: anaconda --token ${{ secrets.ANACONDATOKEN }} upload --user scipp --label main $(ls conda-package-*/*/*.tar.bz2)

manage-versions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to manually clean up the gh-pages branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the settings in the deploy action in docs.yml might wipe that automatically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it. Let's keep an eye on it in the next release.

Build the documentation using

```sh
python -m sphinx -v -b html -d build/.doctrees docs build/html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still uses a build folder. But tox doesn't and the folder is no longer ignored by git.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I opened scipp/copier_template#63.

Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch protection rules need to be updated. Otherwise, lgtm

@SimonHeybrock SimonHeybrock merged commit 0e906cc into main Oct 25, 2023
3 checks passed
@SimonHeybrock SimonHeybrock deleted the move-to-copier branch October 25, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants