-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to copier #170
Move to copier #170
Conversation
- run: tox -e ${{ matrix.tox }} | ||
os: ['ubuntu-20.04'] | ||
python: | ||
- version: '${{needs.formatting.outputs.min_python}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now this only runs with a single python version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I considered keeping multiple versions, but felt there was little benefit at this point.
- run: conda install -c conda-forge --yes anaconda-client | ||
- run: anaconda --token ${{ secrets.ANACONDATOKEN }} upload --user scipp --label main $(ls conda-package-*/*/*.tar.bz2) | ||
|
||
manage-versions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to manually clean up the gh-pages branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the settings in the deploy action in docs.yml
might wipe that automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it. Let's keep an eye on it in the next release.
Build the documentation using | ||
|
||
```sh | ||
python -m sphinx -v -b html -d build/.doctrees docs build/html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still uses a build
folder. But tox doesn't and the folder is no longer ignored by git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I opened scipp/copier_template#63.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch protection rules need to be updated. Otherwise, lgtm
No description provided.