fix: use shape of grouping and not shape of grouping + shape of signal #262
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
This change solves the issue and passes the tests, and it does seem reasonable that we don't care about the shape of the signal when assigning the size of the grouping.
However the removed comment seems to indicate that we do care.
When loading the offending file with this change the
instrument/detector_0
entry gets the somewhat cryptic sizes:sizes={'x_pixel_offset': 1280, 'y_pixel_offset': 1280, 'face': 6, 'vertex': 8, 'winding_order': 24, 'time': 0, 'event_time_zero': 1}
So there's still something wrong here.