-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper: THEIA: An Offline Tool for Tradespace Visualization #920
Conversation
This comment has been minimized.
This comment has been minimized.
Curvenote Preview
|
@samuelcwilliams thanks for the submission! Can you add the DOI for plotly? We can run the checks again after. you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:
|
thanks @samuelcwilliams cheers. |
Overall, this looks good, but I think it would be even more useful if you can show how the data listed at the beginning of the paper is processed to produce the screenshots at the end. Does the user have to type code? If yes, can you include the code? If not, can you then show how this will work with a more complex data type? |
@mihaimaruseac I made some small changes and added in some new content regarding the data upload process and the details on the screenshots in the paper. Let me know if you think there are any areas I should expand on. I appreciate all the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. The logic of this paper itself seems perfect to me. I just didn't quite understand background what Tradespace meant. I would like you to explain in more detail what kind of data you are trying to process.
I'm sorry, I closed the PR by mistake. |
@cbcunc I already finished review :) |
@tkoyama010, I added in some additional details on what tradespace data is. I tried to be concise, as I tend to ramble on sometimes. Let me know of any additional edits that come to mind! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Thanks @tkoyama010 @mihaimaruseac @ssuzana for reviewing the paper! |
If you are creating this PR in order to submit a draft of your paper, please name your PR with
Paper: <title>
. An editor will then add apaper
label and GitHub Actions will be run to check and build your paper.See the project readme for more information.
Editor: Hongsup Shin @hongsupshin
Reviewers: