is generator: add possibility to generate custom tags, and to specify target dir #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phracek
requested changes
May 14, 2024
There was a problem hiding this comment.
Thanks for this pull request.
It would be nice to add into description also some examples, how the imagestream.yaml file is going to be changed.
The code is pretty hard to read. I would prefer to have one class with
one or two methods. Many fields are repeated in CustomTag and LatestTag classes.
phracek
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom tags are needed for backwards compatibility - some of our imagestream tags are already shipped, but are in non-strandard format. We need to make sure we provide these tags in full lifecycle of the image. Until now stream generator was able to generate only standard tags in format - (e.g., 16-el8). With adding custom tags feature we can now specify full tag name any format we like.
See, e.g., in here: sclorg/s2i-nodejs-container#427.