Proper cleanup #397
Merged
Proper cleanup #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: it is already part of the test_application and test_application_user testcases. Moreover it is not clear against which container should be the exec's run.
and use ct_ function for checking result
|
[test-all] |
|
Subscriptions should be solved now. [test-all] |
phracek
approved these changes
Mar 7, 2023
|
@phracek and what about the ssl test I've mentioned? |
|
Merging, as this already has LGTM and the OCP tests are not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments are in the commit messages.
Also I am not really sure about the ssl test. Seem to be incomplete. Can you please take a look at it while reviewing this?