-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: silent flag parameter #415
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 898 898
=========================================
Hits 898 898 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ask for a few changes (we can discuss them if you think otherwise)
I think we could add 2 test in cli.test.js
to cover this new cli behavior
Look forward to read the next iteration, so far so good !
Code Climate has analyzed commit a0208cd and detected 0 issues on this pull request. View more on Code Climate. |
4dd0e50
to
0f8a869
Compare
157a6bb
to
1c7d3b9
Compare
a2df32f
to
3cd72a9
Compare
28e9eec
to
37bd005
Compare
dede7ef
to
7a3ce12
Compare
What does this pull request contain?
Silent Flag to clean the output when --json parameter is not set and the command executed successfully
Does this close any currently open issues?
Resolves #378