fix: review comment - add container name to all service names

Signed-off-by: Ben Meier <[email protected]>

e2e-tests/resources/outputs/example-01-hello-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     command:
       - -c
       - while true; do echo Hello World!; sleep 5; done

e2e-tests/resources/outputs/example-02-environment-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     command:
       - -c
       - while true; do echo Hello $${FRIEND}!; sleep 5; done

e2e-tests/resources/outputs/example-03-dependencies-service-a-output.txt

@@ -1,5 +1,5 @@
 services:
-  service-a:
+  service-a-service-a:
     command:
       - -c
       - 'while true; do echo service-a: Hello $${FRIEND}! Connecting to $${CONNECTION_STRING}...; sleep 10; done'

e2e-tests/resources/outputs/example-03-dependencies-service-b-output.txt

@@ -1,5 +1,5 @@
 services:
-  service-b:
+  service-b-service-b:
     command:
       - -c
       - 'while true; do echo service-b: Hello $${FRIEND}!; sleep 5; done'

e2e-tests/resources/outputs/example-04-extras-output.txt

@@ -1,5 +1,5 @@
 services:
-  web-app:
+  web-app-hello:
     image: nginx
     ports:
       - target: 80

e2e-tests/resources/outputs/run -f example-score.yaml --build test-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     build:
       context: test
     command:

e2e-tests/resources/outputs/run -f example-score.yaml --overrides overrides.yaml-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     command:
       - -c
       - while true; do echo Hello World!; sleep 5; done

e2e-tests/resources/outputs/run -f example-score.yaml -p containers.hello.image=hello:1.1-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     command:
       - -c
       - while true; do echo Hello World!; sleep 5; done

e2e-tests/resources/outputs/run -f example-score.yaml-output.txt

@@ -1,5 +1,5 @@
 services:
-  hello-world:
+  hello-world-hello:
     command:
       - -c
       - while true; do echo Hello World!; sleep 5; done

internal/compose/convert.go

@@ -92,7 +92,7 @@ func ConvertSpec(spec *score.Workload) (*compose.Project, ExternalVariables, err
 		// END (NOTE)
 
 		var svc = compose.ServiceConfig{
-			Name:        spec.Metadata.Name,
+			Name:        spec.Metadata.Name + "-" + containerName,
 			Image:       cSpec.Image,
 			Entrypoint:  cSpec.Command,
 			Command:     cSpec.Args,
@@ -101,14 +101,10 @@ func ConvertSpec(spec *score.Workload) (*compose.Project, ExternalVariables, err
 			Volumes:     volumes,
 		}
 
-		if len(spec.Containers) > 1 {
-			// if we have more than 1 container then namespace them with the container name
-			svc.Name += "-" + containerName
-			// if we are not the "first" service, then inherit the network from the first service
-			if len(project.Services) > 0 {
-				svc.Ports = nil
-				svc.NetworkMode = "service:" + project.Services[0].Name
-			}
+		// if we are not the "first" service, then inherit the network from the first service
+		if len(project.Services) > 0 {
+			svc.Ports = nil
+			svc.NetworkMode = "service:" + project.Services[0].Name
 		}
 
 		project.Services = append(project.Services, svc)

internal/compose/convert_test.go

@@ -67,7 +67,7 @@ func TestScoreConvert(t *testing.T) {
 			Project: &compose.Project{
 				Services: compose.Services{
 					{
-						Name:  "test",
+						Name:  "test-backend",
 						Image: "busybox",
 						Entrypoint: compose.ShellCommand{
 							"/bin/sh",
@@ -137,7 +137,7 @@ func TestScoreConvert(t *testing.T) {
 			Project: &compose.Project{
 				Services: compose.Services{
 					{
-						Name:  "test",
+						Name:  "test-backend",
 						Image: "busybox",
 						Environment: compose.MappingWithEquals{
 							"DEBUG":             stringPtr("${DEBUG}"),