Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Only one workload is included in compose output #26

Closed
williamoverton opened this issue Jan 6, 2023 · 3 comments · Fixed by #46
Closed

[bug] Only one workload is included in compose output #26

williamoverton opened this issue Jan 6, 2023 · 3 comments · Fixed by #46
Assignees
Labels
bug Something isn't working

Comments

@williamoverton
Copy link

Describe the bug
If I have a score.yaml file which defines two workloads, only one workload is included in the output of score-compose

To Reproduce
Steps to reproduce the behavior:

  1. Create a score.yaml file like the following:
apiVersion: score.dev/v1b1

metadata:
  name: app

service:
  ports:
    api:
      port: 80
      targetPort: 3000
    frontend:
      port: 8080
      targetPort: 3000

containers:
  api:
    image: api:latest
  frontend:
    image: frontend:latest
  1. run score-compose:
services:
  app:
    image: frontend:latest
    ports:
      - target: 3000
        published: "80"
      - target: 3000
        published: "8080"

Expected behavior
Both containers should be created and ports should be applied to the correct container.
score-helm seems to work correctly:

containers:
  api:
    image:
      name: api:latest
  frontend:
    image:
      name: frontend:latest
service:
  ports:
    - name: api
      port: 80
      targetPort: 3000
    - name: frontend
      port: 8080
      targetPort: 3000
  type: ClusterIP

Desktop (please complete the following information):

  • OS: macOS Ventura 13.0
  • Version: score-compose 0.1.0 (build: 2022-10-17T09:17:36Z; sha: ef20200)
@williamoverton williamoverton added the bug Something isn't working label Jan 6, 2023
@rachfop
Copy link
Contributor

rachfop commented Jan 6, 2023

I can confirm I'm seeing the same results.

@sujaya-sys sujaya-sys reopened this Jan 23, 2023
@rachfop rachfop mentioned this issue Sep 20, 2023
@astromechza astromechza linked a pull request Feb 2, 2024 that will close this issue
7 tasks
@astromechza
Copy link
Member

Aiming to solve this in #46 which should ensure services get setup for all containers 👍

@astromechza
Copy link
Member

I've merged in a change to latest which should resolve this. You can build it from source or wait for the next release which will be soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants