-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for multiple containers in the same workload #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astromechza
force-pushed
the
support-multiple-containers
branch
2 times, most recently
from
February 1, 2024 11:57
af43231
to
67738ab
Compare
astromechza
requested review from
sujaya-sys,
johanneswuerbach,
delca85,
Nilsty,
chrishumanitec and
TobiasBabin
February 1, 2024 12:11
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
support-multiple-containers
branch
from
February 2, 2024 10:27
67738ab
to
8f972e9
Compare
astromechza
changed the title
feat: added support for multiple containers in the same network
feat: added support for multiple containers in the same workload
Feb 2, 2024
This was referenced Feb 2, 2024
astromechza
force-pushed
the
support-multiple-containers
branch
4 times, most recently
from
February 5, 2024 14:30
0c9d73c
to
64bf5a6
Compare
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
support-multiple-containers
branch
from
February 5, 2024 14:33
64bf5a6
to
ee04030
Compare
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
support-multiple-containers
branch
from
February 5, 2024 14:40
70058f3
to
b8c00e0
Compare
chrishumanitec
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves score-compose by allowing it to support multiple containers in the workload and still support published ports and services.
For example, running an api server and a backend worker in the same workload:
This produces a compose file that looks like:
Note that the services have a container name appended, the ports are only present on the first service, and the other services inherit the network from the first.
What does this PR do?
Note, (3) emulates what Kubernetes and other "pod"-style runtimes do by placing all containers into the same network namespace, thus no two containers in the same workload can bind to the same port! The advantage though is that the published ports do not need to indicate a particular container.
Types of changes
Checklist: