Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of Gulp-Sass #853

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

carpecodeum
Copy link

Description

the version 2.3 of gulp-sass is causing errors
"Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (64)"
on setting up the project on OSX

Related Issue #852

Motivation and Context

this change to version 3.1.0 of gulp sass helps solve the issue of the node sass version being unsupported on the OSX platform having configuration of 64-bit

How Has This Been Tested?

the errors didn't come after upgrading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JaDogg JaDogg changed the title update version of Gulp-Sass Update version of Gulp-Sass Jan 26, 2020
@kmehant
Copy link
Collaborator

kmehant commented Jan 27, 2020

@carpecodeum thanks for the PR
Can you also please check if this change breaks the docker setup thank you. Please let me know.

@carpecodeum
Copy link
Author

@carpecodeum thanks for the PR
Can you also please check if this change breaks the docker setup thank you. Please let me know.

sure @kmehant !!

@carpecodeum
Copy link
Author

@carpecodeum thanks for the PR
Can you also please check if this change breaks the docker setup thank you. Please let me know.

I checked it and it does not break the docker setup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants