Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification #842

Merged
merged 10 commits into from
Jul 23, 2023
Merged

Notification #842

merged 10 commits into from
Jul 23, 2023

Conversation

kushalShukla-web
Copy link
Contributor

Description

changed notification card UI as per given in figma .

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots or GIF (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kushalShukla-web and others added 10 commits July 11, 2023 01:15
… previous it wont accept email that having space after .com and yahoo.com
… previous it wont accept email that having space after .com and yahoo.com
…for more info visit Validate mail pull request
…for more info visit Validate mail pull request
…ous one the component can be render on every page like on login page and sign up page .
… created <MoreHorizOutlinedIcon /> and make it on top of hard right
@kushalShukla-web
Copy link
Contributor Author

@Sarfraz-droid can you pls check this pr :). its just a small change

@kushalShukla-web
Copy link
Contributor Author

@ABHISHEK-PANDEY2 pls go through this pr

@Sarfraz-droid Sarfraz-droid requested review from ABHISHEK-PANDEY2 and Sarfraz-droid and removed request for ABHISHEK-PANDEY2 July 20, 2023 13:20
@Sarfraz-droid
Copy link
Collaborator

Hey @ABHISHEK-PANDEY2 , Can you go through it?

@ABHISHEK-PANDEY2
Copy link
Collaborator

Hey, @kushalShukla-web can you please attach some screenshots of the changes

@kushalShukla-web
Copy link
Contributor Author

Screenshot from 2023-07-22 01-30-39
here change is small . as there is vertical outlined icon is present so i changed that one to horizontal according to figma . and then put style property so that it can go to top right corner of a notification card .

@shivareddy6 shivareddy6 merged commit 9488333 into scorelab:master Jul 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants