Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Createbottomtabnavigator() moved to 'react navigation tabs' #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AbhiKul10
Copy link
Contributor

@AbhiKul10 AbhiKul10 commented Apr 9, 2021

Installing react-navigation-stack library as all navigators have been moved to separate repos, and updating package.json file.
Fixes #126

1) Upgraded buildToolsversion to minimum require for running

2) Added arm64-v8a, as to run the project on android emulator(Apple Macbook Pro M1 chip)

3) Updated classpath to higher version

4) Upgraded react-navigation, react-navigation-stack, react-native-gesture-handler to higher Versions.
Installing react-navigation-stack library as all navigators have been moved to separate repos, and updating package.json file.
@AbhiKul10 AbhiKul10 requested a review from shehand as a code owner April 9, 2021 13:43
@shehand shehand requested a review from Wathsara April 10, 2021 04:50
@@ -96,7 +96,7 @@ def enableProguardInReleaseBuilds = false

android {
compileSdkVersion 28
buildToolsVersion "27.0.3"
buildToolsVersion "29.0.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these commits are not related to this PR. Remove them from this PR or create a single PR containing the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AbhiKul10 AbhiKul10 requested a review from shehand June 4, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createBottomTabNavigator()' has been moved to 'react-navigation-tabs'
2 participants