Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix the issue where Earlybound generation fails when base language is not 1033 and translations are not available #442 #443

Open
wants to merge 2 commits into
base: spkl_dev
Choose a base branch
from

Conversation

erkoolio
Copy link

@erkoolio erkoolio commented Sep 8, 2021

This to fix issue 442 when base language is not 1033 AND there are no translations available.
This will also add PascalCase to optionsets, this is the (Microsoft) way.

Naming service is copied and modified from issue #349, thanks @JannyM85!

This will not break the base functionality in any way.
It does add PascalCase, if that is an issue, then it can be made optional.

@erkoolio erkoolio changed the title Spkl dev To fix the issue where Earlybound generationn fails when base language is not 1033 and translations are not available #442 Sep 8, 2021
@erkoolio erkoolio changed the title To fix the issue where Earlybound generationn fails when base language is not 1033 and translations are not available #442 To fix the issue where Earlybound generation fails when base language is not 1033 and translations are not available #442 Sep 8, 2021
@scottdurow
Copy link
Owner

Thank you for this.
I really thought this issue had been fixed in the most recent release - could you provide repro steps, the error details and version you are using please?

@erkoolio
Copy link
Author

erkoolio commented Oct 13, 2021

To reproduce:
You need an environment with base language 1035 (Finnish).
No other language packages/translations.
Spkl version 1.0.640.

I created a clean project with nothing but SPKL and tried to create early bound classes. Error from console is
CrmSvcUtil Error: 2 : Exiting program with exit code 2 due to exception : System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.
CrmSvcUtil exited with error 2
Error Code=1

I think the beta version worked (1.0.6.3-beta or something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants