Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GIF duration and add other format support #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KnowZero
Copy link

@KnowZero KnowZero commented Nov 10, 2020

- Fixed gif duration via -count_frames
- Now uses codec_name for gif detection instead of filename
- Added support for webm(vp8, vp9) and mkv via -show_entries format
- When all options fail, use ffmpeg decode instead of ffprobe to gather data for formats like mpg (mpeg 2)
- Checks codec_type for video before setting which stream to use ( Should fix issue scottpetrovic#5 )
@KnowZero
Copy link
Author

@scottpetrovic - Hey scott, just wanted to know if I should continue adding features/fixing bugs (maybe try to fix the finding ffmpeg outside of envs and etc?) or is there other plans for this plugin?

@scottpetrovic
Copy link
Owner

@KnowZero - Ohh. I can take a look. I haven't look at this in a little while.

One thing that put this on the backburner was there was work on putting ffmpeg directly in Krita...which would simplify this a lot and it would remove a lot of this code. At least for Windows people, the whole environment variable thing is just too complicated for most people.

I could try to look at this patch. I must have forgotten about it.

@KnowZero
Copy link
Author

KnowZero commented Feb 22, 2021

@scottpetrovic - Hmm, so if ffmpeg is gonna be bundled with Krita, would it make sense for me to attempt to rewrite this in C++ and add it as a native feature?

And it's okay, we all get busy and distracted here and there.

Edit: Just to confirm, ffmpeg is just gonna be put as an executable? Or is the plan to access the shared libraries directly in c++?

@bdsm
Copy link

bdsm commented Apr 16, 2021

I was running into issue #5, tested to see if this worked as a fix and can confirm that this solves it - thank you @KnowZero, I appreciate your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants