Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace md5 with sha512 #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace md5 with sha512 #1075

wants to merge 1 commit into from

Conversation

vvalouch
Copy link

@vvalouch vvalouch commented Sep 12, 2022 •
edited
Loading

MD5 is not FIPS compliant thus I am proposing replacement with SHA512.

@vvalouch
Replace md5 with sha512
8486206 
MD5 is not FIPS compliant thus I am proposing this tiny change.
@vvalouch vvalouch closed this Oct 20, 2022
@vvalouch vvalouch reopened this Oct 20, 2022
@Gallaecio
Copy link
Member

Gallaecio commented Oct 20, 2022 •
edited
Loading

This is not a cryptographic use of md5, I believe, we are not handling unsafe input here, so I do not see the point: a slower algorithm with no added security benefit.

@florin-szilagyi
Copy link

@Gallaecio we should allow some sort of switch
md5 is not FIPS compliant, and will crash on FIPS enabled machines. unless the usedforsecurity=false which is only avaialable on python >3.9

@Gallaecio
Copy link
Member

Sounds like setting usedforsecurity=False on Python 3.9+ is the way forward, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvalouch @Gallaecio @florin-szilagyi