Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for date-formats #1141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added check for date-formats #1141

wants to merge 2 commits into from

Conversation

RyanWalker277
Copy link

Fixes #1020

Code changes

Added a function to check if an input date_string belongs to specefied date_formats or not

Help Required

Even though I did an extremely small code change , It is failing some tests. Can any of the available maintainers help me determine the cause?

cc - @Gallaecio

@RyanWalker277
Copy link
Author

Hey @Gallaecio , I have fixed the test cases issue. It is now passing all the test cases. Kindly review it.

Gallaecio
Gallaecio reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, it feels to me like this change will have no effect whatsoever.

In any case, could you add a test based on the original issue that does not pass before your change and starts passing thanks to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse parsing strings not matching date_formats
2 participants
@RyanWalker277 @Gallaecio