postpone timezone regex evaluation until first use - shaves off time from package import #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from package import
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Oct 2, 2024
It can be expensive to import due to building thousands of regexps at import time (see scrapinghub/dateparser#1181).
5 tasks
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Oct 2, 2024
It can be expensive to import due to building thousands of regexps at import time (see scrapinghub/dateparser#1181).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is related to issue #533 which is caused mainly by a time intensive parsing of regular expressions for timezone matching. This MR introduces a global object
TzRegexCacheand moves preparation of the regexps into it. The regexps are no longer parsed on startup, but during first use instead. On my machine it shaves off about 200 ms from the import time ofdateparserthus reducing it to less than 20 % of the original import time.