Remove scraoy-spider-metadata from requirements.

scrapinghub · Sep 27, 2023 · 71f2b8c · 71f2b8c
1 parent 0a86dc2
commit 71f2b8c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/setup.py b/setup.py
@@ -13,7 +13,6 @@
     install_requires=[
         'Scrapy>=1.6',
         'scrapinghub>=2.1.0',
-        'scrapy-spider-metadata; python_version >= "3.8"'
     ],
     entry_points={
         'console_scripts': [

diff --git a/tests/test_crawl.py b/tests/test_crawl.py
@@ -305,7 +305,6 @@ def test_image_info(tmp_path):
     assert data == expected
 
 
-@pytest.mark.skipif(not SPIDER_METADATA_AVAILABLE, reason="scrapy-spider-metadata is not installed")
 def test_image_info_metadata(tmp_path):
     project_dir = create_project(tmp_path, spider_text="""
 from scrapy import Spider
@@ -321,10 +320,11 @@ class MySpider(Spider):
         "spiders": ["myspider"],
         "metadata": {"myspider": {"foo": 42}},
     }
+    if not SPIDER_METADATA_AVAILABLE:
+        del expected["metadata"]
     assert data == expected
 
 
-@pytest.mark.skipif(not SPIDER_METADATA_AVAILABLE, reason="scrapy-spider-metadata is not installed")
 def test_image_info_metadata_skip_broken(tmp_path):
     project_dir = create_project(tmp_path, spider_text="""
 from scrapy import Spider
@@ -340,4 +340,6 @@ class MySpider(Spider):
         "spiders": ["myspider"],
         "metadata": {},
     }
+    if not SPIDER_METADATA_AVAILABLE:
+        del expected["metadata"]
     assert data == expected
diff --git a/tox.ini b/tox.ini
@@ -10,5 +10,7 @@ deps =
     hubstorage
     packaging
     py36-scrapy16: Scrapy==1.6
+    scrapy-spider-metadata; python_version >= "3.8"
+
 commands =
     pytest --verbose --cov=sh_scrapy --cov-report=term-missing --cov-report=html --cov-report=xml {posargs: sh_scrapy tests}