Skip to content

Commit

Permalink
Normalize the spider params schema.
Browse files Browse the repository at this point in the history
  • Loading branch information
wRAR committed Oct 9, 2023
1 parent 37ec9fa commit dc22d80
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sh_scrapy/commands/shub_image_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def run(self, args, opts):
result['metadata'] = {}
for spider_name in result['spiders']:
spider_cls = self.crawler_process.spider_loader.load(spider_name)
metadata_dict = get_spider_metadata(spider_cls)
metadata_dict = get_spider_metadata(spider_cls, normalize=True)

Check warning on line 48 in sh_scrapy/commands/shub_image_info.py

View check run for this annotation

Codecov / codecov/patch

sh_scrapy/commands/shub_image_info.py#L48

Added line #L48 was not covered by tests
try:
# make sure it's serializable
json.dumps(metadata_dict)
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ deps =
hubstorage
packaging
py36-scrapy16: Scrapy==1.6
scrapy-spider-metadata; python_version >= "3.8"
scrapy-spider-metadata>=0.1.1; python_version >= "3.8"

commands =
pytest --verbose --cov=sh_scrapy --cov-report=term-missing --cov-report=html --cov-report=xml {posargs: sh_scrapy tests}

0 comments on commit dc22d80

Please sign in to comment.