Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sh_scrapy.compat module #67

Merged
merged 11 commits into from
Jan 30, 2023
Merged

Deprecate sh_scrapy.compat module #67

merged 11 commits into from
Jan 30, 2023

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Mar 21, 2022

Use scrapy.utils.python.to_bytes/to_unicode instead, available at least since Scrapy 1.6 which is currently the minimum required version.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #67 (65f1ec7) into master (026fec7) will increase coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 65f1ec7 differs from pull request most recent head e2d8545. Consider uploading reports for the commit e2d8545 to get more accurate results

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   95.06%   95.53%   +0.46%     
==========================================
  Files          14       14              
  Lines         750      739      -11     
==========================================
- Hits          713      706       -7     
+ Misses         37       33       -4     
Impacted Files Coverage Δ
sh_scrapy/compat.py 100.00% <100.00%> (+12.90%) ⬆️
sh_scrapy/env.py 100.00% <100.00%> (ø)
sh_scrapy/extension.py 100.00% <100.00%> (ø)
sh_scrapy/hsref.py 100.00% <100.00%> (ø)
sh_scrapy/log.py 98.09% <100.00%> (ø)
sh_scrapy/settings.py 94.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026fec7...e2d8545. Read the comment docs.

@elacuesta elacuesta changed the title Update compat module Deprecate sh_scrapy.compat module Mar 22, 2022
@elacuesta elacuesta marked this pull request as ready for review March 22, 2022 17:42
Copy link

@MattVieira MattVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe everything is ok, I don't see any limitations, however, I don't feel comfortable evaluating the pull request alone. This time, are we going to wait for another approver?

@elacuesta elacuesta merged commit 2378518 into master Jan 30, 2023
@elacuesta elacuesta deleted the update-compat-module branch January 30, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants